Conversation
|
test pass, not touching c++, safe to merge. @danpovey |
|
@naxingyu I reused Current reader/writer in Pybind may be all removed and use An example for // (fangjun): we follow the PyKaldi style to prepend a underline before the
// registered classes and the user in general should not use them directly;
// instead, they should use the corresponding python classes that are more
// easier to use.
pybind_sequential_table_reader<KaldiObjectHolder<PyClass>>(
m, "_SequentialNnetChainExampleReader");
pybind_random_access_table_reader<KaldiObjectHolder<PyClass>>(
m, "_RandomAccessNnetChainExampleReader");
pybind_table_writer<KaldiObjectHolder<PyClass>>(m,
"_NnetChainExampleWriter"); |
|
I think it makes no sense to create a reader without passing a filename and |
|
I see. That's a really huge PR. I can close this one. |
|
I hope that Dan will merge it soon. We can use LF-MMI training will soon be available in kaldi pybind. |
as discussed in #87