[src] batch renormalization finished#65
Open
GaofengCheng wants to merge 30 commits intodanpovey:svd_draftfrom
Open
[src] batch renormalization finished#65GaofengCheng wants to merge 30 commits intodanpovey:svd_draftfrom
GaofengCheng wants to merge 30 commits intodanpovey:svd_draftfrom
Conversation
…r#2907) [scripts] Fix bug related to multi-task in train_raw_rnn.py. Thx:tessfu2001@gmail.com
…dlium, in accordance with the IS17 paper. (kaldi-asr#2774)
…di-asr#2945) thx: Maxim Korenevsky.
…aldi-asr#2947) note: if this breaks someone's build we'll have to debug it then.
danpovey
reviewed
Jan 5, 2019
| struct Memo { | ||
| // number of frames (after any reshaping). | ||
| int32 num_frames; | ||
| // 'sum_sumsq_scale' is of dimension 5 by block_dim_: |
Owner
There was a problem hiding this comment.
You need to keep the documentation up to date!
But I may rewrite parts of this so this may no end up mattering.
My concern is that the original formulation of BatchNorm does not make sense when minibatch sizes differ and where the stats may differ substantially (e.g. because the language differs).
danpovey
reviewed
Jan 11, 2019
| } | ||
|
|
||
| void BatchRenormComponent::Scale(BaseFloat scale) { | ||
| void BatchRenormComponent::Scale_Training(BaseFloat scale) { |
Owner
There was a problem hiding this comment.
This is against the Google style guide; should be ScaleTraining.
However, I think it would be better to just use the regular Scale() function, you can see how I've done it in my version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have finished the draft of batch-renorm.
I tested it under Switchboard + 2-layer-TDNN-F(without dropout) + 3epoch + 64 batch-size
A: batch-renorm r:1.0 d:0.0
B: batch-renorm r:1.0 d:0.0 -> r:1.2 d:0.4 (at iter 8) -> r:1.6 d:0.8 (at iter 45)
Some notes: