Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 fix: Terms and Conditions Modal Styling #4169

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Conversation

danny-avila
Copy link
Owner

Summary

Closes #4168

  • Refactored the TermsAndConditionsModal to use MarkdownLite instead of Markdown for better performance and lighter rendering.
  • Fixed a modal styling issue where buttons in light mode were not visible or accessible.
  • Updated the SaveAsPresetDialog to use consistent border color styling.
  • Improved the TermsAndConditionsModal layout and button styling for better visibility in both light and dark modes.
  • Refactored the Root component to use a strict boolean check for the terms of service modal acceptance.
  • Updated the TInterfaceConfig type in the data provider to use a string for modalContent instead of string | string[].
  • Bumped the version of the data provider package to 0.7.424.

Testing

To test these changes:

  1. Verify that the TermsAndConditionsModal renders correctly in both light and dark modes.
  2. Check that the buttons in the modal are visible and accessible in light mode.
  3. Ensure that the SaveAsPresetDialog has consistent border styling.
  4. Test the Root component to confirm that the terms of service modal appears when appropriate.
  5. Verify that the MarkdownLite component renders the content correctly in the TermsAndConditionsModal.

Test Configuration:

  • Test in both light and dark modes
  • Test with various screen sizes to ensure responsive design
  • Verify functionality in different browsers (Chrome, Firefox, Safari)

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • My changes do not introduce new warnings
  • I have tested my changes in both light and dark modes
  • I have verified that the TermsAndConditionsModal renders correctly with MarkdownLite

@danny-avila danny-avila added the a11y Accessibility label Sep 20, 2024
@danny-avila danny-avila merged commit 42b7373 into main Sep 20, 2024
2 checks passed
@danny-avila danny-avila deleted the fix/terms-of-service branch September 20, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Terms of Service Buttons (e.g. I accept) not visible in "light mode"
1 participant