Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add artifacts UI for shared links #3940

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

monotykamary
Copy link

@monotykamary monotykamary commented Sep 6, 2024

Pull Request Template

Docker Image: https://github.com/monotykamary/LibreChat/pkgs/container/librechat-dev/269444282?tag=b42c8bf93959f5cb151e32972ad865a261ebb320

compressed_artifacts-shared.mp4

Summary

This PR adds the artifacts UI to the shared link page and resolves #3938. The changes include:

  • Adding the SharedArtifacts component and its related functionality
  • Adding the SharedArtifactButton component
  • Adjusting the ShareView component to include artifact-related elements
  • Updating the layout and styling of the ShareView to accommodate these changes

The motivation behind these changes is to enhance the shared link view by allowing users to view and interact with artifacts associated with shared conversations.

Change Type

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Testing

To test these changes:

  1. Generate a shared link for a conversation that includes artifacts
  2. Open the shared link in a new browser window
  3. Verify that the artifacts panel button is present
  4. Click the button to open the artifacts panel
  5. Ensure that artifacts can be viewed and interacted with correctly
  6. Test the cycling between artifacts and the preview/code tabs

Test Configuration:

  • Browser: Arc
  • LibreChat Version: v0.7.5-rc1 (latest commit on main branch)

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • My changes do not introduce new warnings
  • I have tested my changes thoroughly
  • A pull request for updating the documentation has been submitted

Additional Notes

This change enhances the shared view experience by allowing users to view and interact with artifacts in shared conversations. It provides a more comprehensive view of the conversation content and any associated generated artifacts.

@monotykamary monotykamary force-pushed the feat/artifacts-shared-link branch 6 times, most recently from 185a8f5 to d6b49ee Compare September 15, 2024 12:09
@danny-avila
Copy link
Owner

apologies for the delay on this. the reason is that the artifacts UI is changing soon, so im hesitant to add new components for it

@monotykamary
Copy link
Author

ah no worries, I'll adjust to the new UI if needed

@monotykamary monotykamary force-pushed the feat/artifacts-shared-link branch 3 times, most recently from 71e8a67 to 91db265 Compare September 22, 2024 01:36
@PizBernina
Copy link

hi @monotykamary, thanks for that! Looking forward to using it.
Where will the shared link be hosted? Wasn't able to figure that out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Make artifacts available when sharing links
3 participants