Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Parse markdown in conversation greeting #3898

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

s-diez
Copy link
Contributor

@s-diez s-diez commented Sep 2, 2024

Summary

I added support for Markdown in modelSpecs.greeting similar to the implementation of Markdown support in the enviroment variable CUSTOM_FOOTER.

Change Type

Please delete any irrelevant options.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Testing

I run all tests of npm run test:client, all passed.
I then built the container and started the app. With modelSpecs configured as described below. All types of greetings were rendered.

Test Configuration:

modelSpecs:
  list:
    - name: markdown-greeting
      default: false
      label: Markdown Greeting
      description: "Test Markdown"
      preset:
        endpoint: "azureOpenAI"
        model: gpt-4
        modelLabel: Markdown Greeting
        greeting: |
          ## Welcome to Markdown Greeting

          [LibreChat](https://www.librechat.ai/)
    - name: plain-greeting
      default: false
      label: Markdown Greeting
      description: "Test Plain"
      preset:
        endpoint: "azureOpenAI"
        model: gpt-4
        modelLabel: Markdown Greeting
        greeting: |
          Welcome to Plain Greeting
    - name: no-greeting
      default: false
      label: No Greeting
      description: "Test no greeting"
      preset:
        endpoint: "azureOpenAI"
        model: gpt-4
        modelLabel: No Greeting

Checklist

Please delete any irrelevant options.

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • Local unit tests pass with my changes
  • A pull request for updating the documentation has been submitted.

See LibreChat-AI/librechat.ai#118 for documentation change

@todiadiyatmo
Copy link

Seems very needed improvement for the greeting message !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants