Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗨️ fix: Reset prompt groups query when changing filters #3294

Merged

Conversation

meroo36
Copy link
Contributor

@meroo36 meroo36 commented Jul 8, 2024

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Testing

Create at least 11 different prompts in the prompts library. Go to the next page. Use the keyword filter and then remove it. You should still be able to use the pagination feature.

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • My changes do not introduce new warnings
  • Local unit tests pass with my changes

@meroo36
Copy link
Contributor Author

meroo36 commented Jul 8, 2024

Issue #3290

@meroo36
Copy link
Contributor Author

meroo36 commented Jul 9, 2024

this also fixes #3289

@danny-avila danny-avila changed the title fix: Reset prompt groups query when changing filters 🗨️ fix: Reset prompt groups query when changing filters Jul 10, 2024
@danny-avila danny-avila merged commit 7d5b03d into danny-avila:main Jul 10, 2024
@danny-avila
Copy link
Owner

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants