Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🕑 fix: Add Suspense to Connection Error Messages #3074

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

danny-avila
Copy link
Owner

@danny-avila danny-avila commented Jun 15, 2024

Summary

I added a Suspense component to handle and display connection error messages more gracefully. This improves the user experience by allowing the interface to show a loading state while the Error may still yet resolve

  • Added Suspense component to connection error message handling.
  • Modified error handling logic to integrate with Suspense.
  • Updated relevant components to support the new error handling approach.
  • Updated useDelayedRender to return a promise for proper Suspense fallback mechanism
  • No longer show hover buttons for error messages
  • Render assistant icon/name for Assistant Error messages

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes

@danny-avila danny-avila merged commit 2cf5228 into main Jun 15, 2024
2 checks passed
@danny-avila danny-avila deleted the style/delay-error-message branch June 15, 2024 20:16
kenshinsamue pushed a commit to intelequia/LibreChat that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant