Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #13364 (CI: Use Cppcheck Premium 24.11.0 in cppcheckpremium.yml) #7054

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

danmar
Copy link
Owner

@danmar danmar commented Nov 30, 2024

No description provided.

@danmar danmar merged commit 588ca87 into danmar:main Dec 1, 2024
60 checks passed
@danmar danmar deleted the fix-13364 branch December 1, 2024 10:03
premium_version=24.9.0.1
premium_version=24.11.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you considered adding a /latest/ link?

Pro:

  • code says what it means; use the latest

Con:

  • external change can effect CI (i.e. update posted, CI now fails)

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the explicit version, I don't have the intention to always run latest Cppcheck Premium it's just that there has been important problems with older releases that I wanted to avoid so I have used latest in practice.. An important Pro with an explicit version is that it will be seen easily later (for instance 10 years from now) which exact version we used when checking a particular cppcheck-release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants