Fixed exception dispatch idiom not being recognized in the middle of a function #6490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry about the failed build, I mistakenly built with an older version of the source. Should be good now. |
danmar
reviewed
Jun 9, 2024
| for (const Token *tok = function->functionScope->bodyStart->next(); | ||
| tok != function->functionScope->bodyEnd; tok = tok->next()) { | ||
| tok != function->functionScope->bodyEnd && | ||
| !Token::simpleMatch(tok, "try { throw ; } catch ("); tok = tok->next()) { |
There was a problem hiding this comment.
hmm you could also put this condition in the loop body.
if (Token::simpleMatch(tok, "try { throw ; } catch ("))
break;
I don't have a really strong opinion but feel that it's imho a bit preferable since the loop condition will be easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing check for the exception dispatch idiom only checks the beginning of a function. This PR checks the entire function for the idiom, and adds 3 new unit tests.