Skip to content

Commit

Permalink
do not persist checkout credentials in GitHub workflows (#7044)
Browse files Browse the repository at this point in the history
  • Loading branch information
firewave authored Nov 27, 2024
1 parent 93ea424 commit 988c79e
Show file tree
Hide file tree
Showing 20 changed files with 64 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/CI-cygwin.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: Set up Cygwin
uses: cygwin/cygwin-install-action@master
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/CI-mingw.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: Set up MSYS2
uses: msys2/setup-msys2@v2
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/CI-unixish-docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: Install missing software on ubuntu
if: contains(matrix.image, 'ubuntu')
Expand Down Expand Up @@ -92,6 +94,8 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: Install missing software on ubuntu
if: contains(matrix.image, 'ubuntu')
Expand Down
14 changes: 14 additions & 0 deletions .github/workflows/CI-unixish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: ccache
uses: hendrikmuhs/[email protected]
Expand Down Expand Up @@ -98,6 +100,8 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: ccache
uses: hendrikmuhs/[email protected]
Expand Down Expand Up @@ -172,6 +176,8 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: ccache
uses: hendrikmuhs/[email protected]
Expand Down Expand Up @@ -204,6 +210,8 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: ccache
uses: hendrikmuhs/[email protected]
Expand Down Expand Up @@ -236,6 +244,8 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

# coreutils contains "g++" (default is "c++") and "nproc"
- name: Install missing software on macos
Expand All @@ -258,6 +268,8 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: ccache
uses: hendrikmuhs/[email protected]
Expand Down Expand Up @@ -426,6 +438,8 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: ccache
uses: hendrikmuhs/[email protected]
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/CI-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: Set up Visual Studio environment
uses: ilammy/msvc-dev-cmd@v1
Expand Down Expand Up @@ -86,6 +88,8 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: Set up Python 3.13
if: matrix.config == 'release'
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/asan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: ccache
uses: hendrikmuhs/[email protected]
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/buildman.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ jobs:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- run: |
mkdir output
Expand All @@ -45,6 +47,8 @@ jobs:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: Install missing software on ubuntu
run: |
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/clang-tidy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: Install missing software
run: |
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ jobs:
steps:
- name: Checkout repository
uses: actions/checkout@v4
with:
persist-credentials: false

- name: Install missing software on ubuntu
run: |
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: ccache
uses: hendrikmuhs/[email protected]
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/coverity.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ jobs:
if: ${{ github.repository_owner == 'danmar' }}
steps:
- uses: actions/checkout@v4
with:
persist-credentials: false
- name: Install missing software on ubuntu
run: |
sudo apt-get update
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/cppcheck-premium.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ jobs:
runs-on: ubuntu-24.04 # run on the latest image only
steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: Download cppcheckpremium
run: |
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/format.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: Cache uncrustify
uses: actions/cache@v4
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/iwyu.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: Install missing software on debian/ubuntu
if: contains(matrix.image, 'debian')
Expand Down Expand Up @@ -158,6 +160,8 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: Install missing software
run: |
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/release-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: Set up Visual Studio environment
uses: ilammy/msvc-dev-cmd@v1
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/scriptcheck.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: ccache
uses: hendrikmuhs/[email protected]
Expand Down Expand Up @@ -57,6 +59,8 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

# TODO: bailout on error
- name: Restore Cppcheck
Expand Down Expand Up @@ -193,6 +197,8 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: run dmake
run: |
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/selfcheck.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: ccache
uses: hendrikmuhs/[email protected]
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/tsan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: ccache
uses: hendrikmuhs/[email protected]
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/ubsan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: ccache
uses: hendrikmuhs/[email protected]
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/valgrind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
persist-credentials: false

- name: ccache
uses: hendrikmuhs/[email protected]
Expand Down

0 comments on commit 988c79e

Please sign in to comment.