Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract panelreel core into its own library #43

Closed
dankamongmen opened this issue Sep 19, 2019 · 6 comments
Closed

Extract panelreel core into its own library #43

dankamongmen opened this issue Sep 19, 2019 · 6 comments
Assignees
Labels
Milestone

Comments

@dankamongmen
Copy link
Owner

The ncurses code is horrible intertwined with all kinds of core crap. Get it extracted, and move it into its own library. Then, unify it with the omphalos implementation, and get that refactored as well.

@dankamongmen
Copy link
Owner Author

I've created https://github.com/dankamongmen/outcurses, which will be a fine place for this stuff to go.

@dankamongmen
Copy link
Owner Author

This is moving along. I've been recreating the functionality in outcurses, but it goes slowly, with many interruptions. Thankfully, I fixed #23 , which takes a lot of heat off of the curses UI code.

I'd love to have this done in 1.2, but don't yet want to commit.

@dankamongmen
Copy link
Owner Author

Outcurses has most of the panelreel abstraction now, and it's working better than this ever did. We ought be able to start converting late next week, I'd think.

@dankamongmen
Copy link
Owner Author

dankamongmen added a commit that referenced this issue Dec 7, 2019
@dankamongmen
Copy link
Owner Author

This is well along its way. Using notcurses 0.9.0, we have the following:

2019-12-18-172622_722x1417_scrot

Obviously there are some glitches still, but this is just about there, with several thousand fewer lines of code.

@dankamongmen dankamongmen changed the title Extract ncurses core into its own library Extract panelreel core into its own library Dec 20, 2019
@dankamongmen dankamongmen added this to the 1.2 milestone Dec 20, 2019
@dankamongmen dankamongmen added the notcurses notcurses ui label Dec 20, 2019
dankamongmen added a commit that referenced this issue Dec 25, 2019
Coarse conversion to notcurses #70. We're still building both for now. notcurses version has some rough edges for sure.
@dankamongmen
Copy link
Owner Author

I've merged growlight in its notcurses variant. There are still some rough edges, but they now deserve their own subbugs. w00t!

@dankamongmen dankamongmen modified the milestones: 1.2.1, 1.3 Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant