Adjust label extension

danielsaidi · Apr 29, 2024 · ad529f1 · ad529f1
1 parent a80772c
commit ad529f1
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -4,6 +4,14 @@ SwiftUIKit makes its best effort to honor semver, but breaking changes can occur
 
 
 
+## 4.2.3
+
+### 💡 Behavior changes
+
+* `Label` now used `LocalizedStringKey` for its title. 
+
+
+
 ## 4.2.2
 
 ### 🐛 Bug fixes

diff --git a/Sources/SwiftUIKit/Extensions/Label+Init.swift b/Sources/SwiftUIKit/Extensions/Label+Init.swift
@@ -11,7 +11,7 @@ import SwiftUI
 public extension Label where Icon == Image, Title == Text {
 
     /// Create a label with a string and a plain image icon.
-    init(_ text: String, image: Image) {
+    init(_ text: LocalizedStringKey, image: Image) {
         self.init {
             Text(text)
         } icon: {

diff --git a/Sources/SwiftUIKit/Lists/ListButtonGroup.swift b/Sources/SwiftUIKit/Lists/ListButtonGroup.swift
@@ -96,7 +96,7 @@ private extension ButtonStyle where Self == ListButtonGroupStyle {
 private extension String {
 
     func previewButton(_ icon: Image) -> some View {
-        Button {} label: { Label(self, image: icon) }
+        Button {} label: { Label(LocalizedStringKey(self), image: icon) }
     }
 }