fix: honor -stderrthreshold even when -logtostderr=true#519
Open
pierluigilenoci wants to merge 1 commit intodanielqsj:masterfrom
Open
fix: honor -stderrthreshold even when -logtostderr=true#519pierluigilenoci wants to merge 1 commit intodanielqsj:masterfrom
pierluigilenoci wants to merge 1 commit intodanielqsj:masterfrom
Conversation
klog v2 defaults -logtostderr=true, which silently ignores -stderrthreshold. klog v2.140.0 introduced the legacy_stderr_threshold_behavior flag to fix this (kubernetes/klog#432). Set legacy_stderr_threshold_behavior=false and stderrthreshold=INFO after klog.InitFlags() so that operators can use -stderrthreshold to control which severity levels go to stderr. Also bump k8s.io/klog/v2 from v2.130.1 to v2.140.0. Ref: kubernetes/klog#212, kubernetes/klog#432 Signed-off-by: Pierluigi Lenoci <pierluigi.lenoci@gmail.com> Signed-off-by: Pierluigi Lenoci <pierluigilenoci@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
klog v2 defaults
-logtostderr=true, which silently ignores-stderrthreshold. klog v2.140.0 introduced thelegacy_stderr_threshold_behaviorflag to decouple the two(kubernetes/klog#432).
This PR:
k8s.io/klog/v2from v2.130.1 to v2.140.0.klog.InitFlags(), setslegacy_stderr_threshold_behavior=falseand
stderrthreshold=INFOso that operators can control which severitylevels go to stderr via the standard
-stderrthresholdflag.Why
Without this fix, passing
-stderrthreshold=ERROR(or any other value) tokafka_exporterhas no effect — all log levels still go to stderr because-logtostderr=trueunconditionally overrides-stderrthreshold.Ref