New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix piping to commands by letting process exit naturally #41

Merged

danielpigott merged 1 commit into danielpigott:master from mmalecki:fix-piping

Oct 5, 2018

Contributor

mmalecki commented Oct 4, 2018

Node.js' process.stdout is asynchronous when connected to a
pipe,
so forcing an earlier process.exit() results in incomplete data being
output to the pipe.

This fixes usecases like cfcli ls -f json | json.


          Fix piping to commands by letting process exit naturally

e43a7e9

[Node.js' `process.stdout` is asynchronous when connected to a
pipe](https://github.com/nodejs/node/blob/master/doc/api/process.md#a-note-on-process-io),
so forcing an earlier `process.exit()` results in incomplete data being
output to the pipe.

This fixes usecases like `cfcli ls -f json | json`.

danielpigott merged commit 5c05f90 into danielpigott:master

Owner

danielpigott commented Oct 5, 2018

Thanks @mmalecki I have published this as v3.2.1

mmalecki deleted the fix-piping branch

October 5, 2018 10:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet