Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZSTD_decompressStream() fuzzer fix #5

Merged
merged 4 commits into from
Oct 10, 2022
Merged

Conversation

daniellerozenblit
Copy link
Owner

No description provided.

@daniellerozenblit
Copy link
Owner Author

daniellerozenblit commented Sep 12, 2022

This PR changes some of the logic in a previous PR (#3258) in response to a failing oss-fuzz test.

In the previous PR, we skip the flush operation in the case of a op=NULL. This causes an assertion failure later on when checking for forward progress.

Instead of skipping the entire flush operation, we now simply use a ternary operator to increment op when it is non-null.

@daniellerozenblit daniellerozenblit merged commit cb6dc32 into dev Oct 10, 2022
@daniellerozenblit daniellerozenblit deleted the null-buffer-decompress branch October 24, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant