(set-binary) update npartoftype array when particle types are set according to a specific star in a binary #596
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Bug fix (found by @msha0023)
Description:
When setting up two gas-particle stars in a binary using
SETUP=binary
withrelax_star
, the second star is not relaxed because of an error raised bychecksetup
called in `relax_star:The cause of this is that the
npartoftype
array was not updated when particles from star 1 were set to the typeitype+ioffset
, causing a mismatch withiphase
. I have now ensurednpartoftype
is updated whenever particle types are changed.