Repository navigation
Studio: keep Qwen-Image-2.1 image conditioning finite on ROCm - #267
Closed
shimmyshimmer wants to merge 3 commits into
Closed
shimmyshimmer wants to merge 3 commits into
shimmyshimmer wants to merge 3 commits into
Conversation
danielhanchen
force-pushed
the
mirror-pr-12360
branch
2 times, most recently
from
October 1, 2026 09:13
1fc65cf to
ea15bc0
Compare
danielhanchen
force-pushed
the
mirror-pr-12360
branch
from
October 1, 2026 09:13
ea15bc0 to
8e4ce5b
Compare
Owner
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qwen-Image-2.1 reference-image generation produces NaN conditioning and blank images on Radeon 8060S with native vision SDPA, on both Windows and Linux.
Fix
Use eager attention in 512-query-row chunks for the encoder's Qwen3-VL vision tower, retaining all keys and values. This avoids native SDPA's NaNs without the memory cost of unbounded eager attention. The language model, denoiser and global SDPA settings stay unchanged, and the fix applies with Speed Off too.
Default to ROCm gfx1151 only.
UNSLOTH_QWEN_IMAGE_ROCM_VISION_EAGER=0opts out;=1enables testing on other ROCm GPUs. Preserve explicitly selected non-SDPA backends and report installation failures instead of silently skipping the fix.Tests
Windows/Linux A/B on Radeon 8060S, PyTorch 2.11 / ROCm 7.13:
148 focused and related tests pass after rebasing onto
b1c522a4ea; Ruff and formatting checks pass. Hardware A/B used4e8503e437and was not repeated after the rebase and override/error-handling changes. The attention calculation is unchanged.RX 7900 XT and other ROCm architectures remain untested.
Mirror of unslothai/unsloth#12360 by @oobabooga, opened for review only.
Do not merge here. Fixes agreed on this mirror must be applied to the source PR.
Source description digest at mirror time:
0f70eb639f50