validate-may21-prs: cross-OS CI for May 18-21 PR cohort#137
Open
danielhanchen wants to merge 7 commits into
Open
validate-may21-prs: cross-OS CI for May 18-21 PR cohort#137danielhanchen wants to merge 7 commits into
danielhanchen wants to merge 7 commits into
Conversation
Trims 22 heavy/redundant workflows and adds a single targeted validate-may21-prs.yml that runs the touched backend tests for the May 18-21 2026 PR cohort across ubuntu-latest, macos-14, windows-latest. Covers: PR unslothai#5603 sandbox hardening -> test_sandbox_hardening.py PR unslothai#5582 MTP --spec-draft-n-max -> test_llama_cpp_mtp_detection.py test_gguf_reload_inheritance.py PR unslothai#5604 lockfile audit -> test_lockfile_supply_chain_audit.py + the audit script itself All tests are CPU-only under the conftest CUDA spoof. Workflow is push-gated on the validate-may21-prs branch with cancel-in-progress to stay below the 5-concurrent Windows runner cap.
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This was referenced May 21, 2026
Each PR ran the same staged source files before, which went stale when the upstream PR commits advanced. Refactor to one job per PR with an actions/checkout of that PR's head ref, so cross-OS validation always uses the latest commit: - PR unslothai#5603 sandbox -> studio-sandbox-hardening - PR unslothai#5620 parser parity -> studio-tools-multi-format-v2 - PR unslothai#5696 mtp reload guards -> followup-mtp-reload-guards (unslothai#5582 followup) - PR unslothai#5695 lockfile audit -> followup-lockfile-audit-regressions (unslothai#5604 followup) 4 jobs x 3 OSes = 12 runs; Windows = 4 (below the 5-concurrent cap). cancel-in-progress per (workflow, ref) keeps iteration cheap. All tests stay CPU-only and rely on the CUDA spoof harness in tests/conftest.py + tests/_zoo_aggressive_cuda_spoof.py, so no real GPU is required on any runner.
unslothai#5620 parser tests transitively import the safetensors loop, which needs the datasets package. unslothai#5696 route-guard tests import routes/inference.py, which transitively imports core/training (uses matplotlib). Add both, plus the auth deps (pyjwt/cryptography/ aiosqlite/python-multipart) needed for any test that touches the FastAPI route module so route-level imports resolve cleanly on all three OSes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate-may21-prs.ymlthat runs the touched backend tests for the May 18-21 2026 PR cohort acrossubuntu-latest,macos-14,windows-latest.tests/conftest.pyCUDA spoof, so they finish on vanilla GitHub runners without GPUs.Coverage
studio/backend/tests/test_sandbox_hardening.py--spec-draft-n-maxstudio/backend/tests/test_llama_cpp_mtp_detection.py,studio/backend/tests/test_gguf_reload_inheritance.pytests/security/test_lockfile_supply_chain_audit.py+python3 scripts/lockfile_supply_chain_audit.pyTest plan
ubuntu-latestjob greenmacos-14job greenwindows-latestjob green