[staging] e2e Studio q2_k_l GGUF export validation (Linux / macOS / Windows)#127
Closed
danielhanchen wants to merge 3 commits into
Closed
[staging] e2e Studio q2_k_l GGUF export validation (Linux / macOS / Windows)#127danielhanchen wants to merge 3 commits into
danielhanchen wants to merge 3 commits into
Conversation
Adds .github/workflows/studio-export-q2kl-e2e.yml that:
1. Builds llama.cpp from source on each OS via install_llama_cpp()
(apt-installed build deps on Linux; cmake + system toolchain on
macOS / Windows). CUDA spoof preamble matches the existing
consolidated-tests-ci.yml llama-cpp-smoke job.
2. Locates the freshly-built llama-quantize binary (build/bin/Release/
on Windows, top-level on macOS / Linux).
3. Asserts llama-quantize --help advertises q2_k AND the two preset
flags (--output-tensor-type, --token-embedding-type) so the
CLI surface still matches what unsloth_zoo emits on this OS.
4. Imports the patched unsloth_zoo from the staging fork branch
(danielhanchen/unsloth-zoo-staging-1@studio-export-q2kl-fix),
captures the command quantize_gguf emits for quant_type='q2_k_l',
and asserts the post-expansion tokens are present and the literal
preset name does NOT leak through.
This is the diagnostic regression check for the user-reported error
main: invalid ftype 'q2_k_l'
on Apple Silicon Studio export.
Trims 22 unrelated workflow files on this branch only (leaving
lint-ci.yml + wheel-smoke.yml + the new e2e workflow). Drop is staging-
only hygiene -- not intended for upstream unslothai/unsloth.
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
added 2 commits
May 18, 2026 10:57
… keep pip-install + command-capture e2e
Merged
5 tasks
Owner
Author
|
Throwaway dry-run, validated end-to-end on Linux / macOS / Windows runners. Real fix is at unslothai/unsloth-zoo#667. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway staging PR validating the Studio q2_k_l GGUF export fix end-to-end on real Linux / macOS / Windows runners. Do not merge — close after CI confirms green.
Pairs with unsloth-zoo-staging-1#18 (already green on all 3 OS for the unit-test layer); this PR validates the binary-toolchain layer:
install_llama_cpp().llama-quantize --helpadvertisesq2_kAND the two preset flags (--output-tensor-type,--token-embedding-type) — proving the CLI surface still matches whatunsloth_zooemits.unsloth_zoofrom the staging-1 branch, capture the commandquantize_gguf(quant_type='q2_k_l')would emit, assert the post-expansion command is correct.Diagnostic regression check for:
main: invalid ftype 'q2_k_l'on Apple Silicon.Changes on this branch
+.github/workflows/studio-export-q2kl-e2e.yml— 3-OS matrix,max-parallel: 3to stay under the 5-Windows-runner cap,concurrency.cancel-in-progress: true,paths:filter so unrelated commits don't re-fire it.−22 unrelated workflow files (this branch only) — keeps push fan-out bounded. Branch retainslint-ci.yml+wheel-smoke.yml+ the new e2e workflow.Test plan