Fix compilation of fields named 'bytes' or 'str' #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if you have a field named "bytes" using the bytes type, it doesn't work.
Merged
cetanu
approved these changes
Apr 6, 2021
This was referenced Oct 26, 2021
Gobot1234
pushed a commit
that referenced
this pull request
Dec 1, 2021
* Revert "Fix compilation of fields named 'bytes' or 'str' (#226)" This reverts commit deb623e. * Fix compilation of fileds with name identical to their type * Added test for field-name identical to python type Co-authored-by: Guy Szweigman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #193 (because I didn't have write access).
I enabled the previously xfail marked namespace_builtin_types test case and tweaked the code from @SpencerSharkey to fully cover it.