Skip to content

Conversation

@Gobot1234
Copy link
Collaborator

No description provided.

@nat-n
Copy link
Collaborator

nat-n commented Jan 24, 2021

Nice catch. Would be good to have a test for this.

@nat-n nat-n mentioned this pull request Jan 25, 2021
@Gobot1234
Copy link
Collaborator Author

Only found this due to #187 and code using an int would be invalid

message Test {
    bool value = 1;
    string 23 = 2;
}

@nat-n
Copy link
Collaborator

nat-n commented Jan 26, 2021

Only found this due to #187 and code using an int would be invalid

message Test {
    bool value = 1;
    string 23 = 2;
}

Do you mean that there isn't actually a real scenario that would trigger the bug caused here?

@Gobot1234
Copy link
Collaborator Author

Gobot1234 commented Jan 26, 2021

Only found this due to #187 and code using an int would be invalid

message Test {
    bool value = 1;
    string 23 = 2;
}

Do you mean that there isn't actually a real scenario that would trigger the bug caused here?

It could be if #187 was merged.

@nat-n nat-n added the bug Something isn't working label Apr 6, 2021
@Gobot1234
Copy link
Collaborator Author

I'm gonna merge this with #187

@Gobot1234 Gobot1234 closed this Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants