Skip to content

REF: Refactor plugin.py to use modular dataclasses in tree-like structure to represent parsed data #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boukeversteegh merged 23 commits into from
Jul 25, 2020
Merged

REF: Refactor plugin.py to use modular dataclasses in tree-like structure to represent parsed data #121

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
6e2d8a7
rebase onto latest master
adriangb Jul 15, 2020
e60791b
fix bugs
adriangb Jul 16, 2020
46c1035
add import
adriangb Jul 16, 2020
faea404
fix map type detection
adriangb Jul 16, 2020
092076b
formatting fixes
adriangb Jul 16, 2020
e58bbe1
nested msg fix
adriangb Jul 16, 2020
d51a5b1
blacken
adriangb Jul 16, 2020
cefd73f
mutable defaults fix
adriangb Jul 16, 2020
f2b81bd
more mutable default arg fixes
adriangb Jul 16, 2020
a77e462
fixes
adriangb Jul 16, 2020
514548d
routing fix
adriangb Jul 16, 2020
e970c5a
fix all tests
adriangb Jul 17, 2020
01345c5
black
adriangb Jul 17, 2020
8858a34
revert changes to Makefile
adriangb Jul 17, 2020
6747a23
python3.6 support
adriangb Jul 17, 2020
586bb01
restructure files
adriangb Jul 17, 2020
f9dd7eb
docs
adriangb Jul 17, 2020
62eea35
file cleanup
adriangb Jul 17, 2020
ecd4b5a
structure changes
adriangb Jul 17, 2020
0fdb181
restructure, rename
adriangb Jul 19, 2020
8a99cbd
blacken
adriangb Jul 19, 2020
66610b0
fix comment
adriangb Jul 20, 2020
6f52343
clarify variable names
adriangb Jul 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ help: ## - Show this help.
generate: ## - Generate test cases (do this once before running test)
poetry run python -m tests.generate

test: ## - Run tests
poetry run pytest --cov betterproto
test: ## - Run tests, ingoring collection errors (ex from missing imports)
poetry run pytest --cov betterproto --continue-on-collection-errors

@adriangb adriangb Jul 16, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is obviously not needed for this PR, but I found it very useful, will remove before final review.


types: ## - Check types with mypy
poetry run mypy src/betterproto --ignore-missing-imports
Expand Down
Loading