Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify compatible releases for installation #358

Merged
merged 3 commits into from
Dec 9, 2022

Conversation

jangop
Copy link
Contributor

@jangop jangop commented Dec 7, 2022

This is to address #355.

By specifying compatible releases, we allow installation of rembg within other projects that have similar dependencies.

In addition, we include github actions to test installations of rembg with versions of dependencies determined by pip at the time the tests are run.

For more information on compatible releases,
see [PEP 440](https://peps.python.org/pep-0440/#compatible-release)
or [pip's requirement specifiers](https://pip.pypa.io/en/stable/reference/requirement-specifiers/).

In general, `requirements.txt` should be used to define a repeatable installation,
such as a development environment or a production environment.
As such, versions of dependencies contained therein should be as specific as possible.

`install_requires` should be used to indicate dependencies necessary to run the package.
As such, versions of dependencies contained therein should be as broad as possible.

See [“install_requires vs requirements files” on python.org](https://packaging.python.org/en/latest/discussions/install-requires-vs-requirements/)
or [“requirements.txt vs setup.py” on stackoverflow](https://stackoverflow.com/a/43659126) for more information.

Closes danielgatis#355
Copy link
Owner

@danielgatis danielgatis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 👏

@danielgatis danielgatis merged commit 1961a36 into danielgatis:main Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants