[FTR] feature/thread-limiter | Add anyio thread limiter #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wow! thank you so much! |
|
@danielgatis do you have an idea when a new version with this PR will release ? please 🙏 |
https://github.com/danielgatis/rembg/releases/tag/v2.0.25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue explained in #289 by limiting the number of threads in the managed thread pool by
anyio.Relate to the discussion in #tiangolo/fastapi/4221 and an additional click option is added to specify the number of threads. This PR should serve as an extension to the current implementation and if no thread limit is specified the server should work as previously and thus be able to reproduce #289.
However, if a thread limit is specified the response time will increase proportionally to the number of simultaneous requests, thus avoiding spawning threads until memory is filled.