node.fontSize value now overrides config.node.fontSize value #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lironhl
force-pushed
the
fix/node_font_size_overrides_config_node_font_size
branch
from
1b1617c
to
3dc029d
Compare
lironhl
force-pushed
the
fix/node_font_size_overrides_config_node_font_size
branch
from
3dc029d
to
27abe77
Compare
danielcaldas
approved these changes
Oct 7, 2020
danielcaldas
added a commit
that referenced
this pull request
Oct 7, 2020
danielcaldas
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #330
This fixes the issue where individual nodes couldn't get specific
fontSizeorhighlightFontSizevalues.Here's the before & after of the behaviors.
Before
After