Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/initial zoom #289

Merged
merged 5 commits into from
May 17, 2020
Merged

Feature/initial zoom #289

merged 5 commits into from
May 17, 2020

Conversation

Morta1
Copy link
Contributor

@Morta1 Morta1 commented Jan 14, 2020

No description provided.

danielcaldas
danielcaldas requested changes Mar 1, 2020
View reviewed changes
Copy link
Owner

@danielcaldas danielcaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 👍 , dropped a few comments

package.json Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
docs/DOCUMENTATION.md Outdated Show resolved Hide resolved
sandbox/graph-config-tooltips.js Outdated Show resolved Hide resolved
src/components/graph/graph.config.js Outdated Show resolved Hide resolved
src/components/graph/Graph.jsx Outdated Show resolved Hide resolved
src/components/graph/graph.config.js Outdated Show resolved Hide resolved
@danielcaldas
Copy link
Owner

Hey, @Morta1 I think this feature is very useful, perhaps you could add a bit more of context/motivation for you to purpose this change?

@antoninklopp
Copy link
Collaborator

antoninklopp commented Apr 13, 2020 •
edited
Loading

@Morta1 any update on this? It would be a great addition

@StevenHeven
Copy link

Pleaze resolve conflict ! It will be very helpful ! Can you notice me when it merge please ?
I've got some bug with focusZoom in confing not work and i think initial zoom will fix that ! :P

@daiboom
Copy link

daiboom commented Apr 24, 2020

This PR is a feature I need.

@Morta1
Copy link
Contributor Author

Morta1 commented Apr 27, 2020

@danielcaldas I've updated the PR.
The PR was originally created to increase the initial zoom of the graph.
The initial zoom of the graph was too far for my needs so I've added this small adjustment.

@danielcaldas danielcaldas self-requested a review May 17, 2020 09:46
danielcaldas
danielcaldas approved these changes May 17, 2020
View reviewed changes
Copy link
Owner

@danielcaldas danielcaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @Morta1! Just some feedback tough, try to add descriptions to PRs even for the minor change, this will speed up a lot the release process when we need to compile all the changes that have been merged until that point.

@danielcaldas danielcaldas merged commit bce1cb0 into danielcaldas:master May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielcaldas danielcaldas danielcaldas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Morta1 @danielcaldas @antoninklopp @StevenHeven @daiboom