Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node_label changes enabled local param for renderLabel #267

Merged
merged 1 commit into from
Nov 30, 2019

Conversation

gopherine
Copy link
Contributor

#192 i added renderlabel it took so much time because i am not able to reproduce the problem in my local however i understand the problem of OP this i have made this changes.

Also regarding my earlier changes in this repo when i install the library i dont see the change i am still not able to change localLink but it works fine on the hosted example but not on my project
regards
Atharva

Copy link
Owner

@danielcaldas danielcaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this, this will work just fine 👍

@@ -206,7 +206,7 @@ function buildNodeProps(node, config, nodeCallbacks = {}, highlightedNode, highl
label,
opacity,
overrideGlobalViewGenerator: !node.viewGenerator && node.svg,
renderLabel: config.node.renderLabel,
renderLabel: node.renderLabel || config.node.renderLabel,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will work just fine, basically, if no renderLabel is defined at node level we fallback to global 👍

@danielcaldas danielcaldas merged commit 539a03a into danielcaldas:master Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants