Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renderLabel params are not working for single node #322

Closed
volkantas opened this issue May 5, 2020 · 3 comments · Fixed by #327
Closed

renderLabel params are not working for single node #322

volkantas opened this issue May 5, 2020 · 3 comments · Fixed by #327
Labels
bug priority high

Comments

@volkantas
Copy link

Describe the bug
node.fontSize and node.renderLabel parameters are not working for single node.

To Reproduce
Steps to reproduce the behavior:

  1. Go to demo page
  2. Add new node parameters as 'fontSize: 20' or 'renderLabel: false'
  3. You will see nothing will be changed on demo app

Expected behavior
fontSize parameter must be effect nodes font size
renderLabel parameter must be show or hide nodes label

Screenshots
Ekran Resmi 2020-05-05 16 40 56

Environment:

  • OS: [macOS]
  • Browser [chrome]
@danielcaldas
Copy link
Owner

Hi @volkantas thanks for reporting.

  • renderLabel - this is a bug, we will fix it.
  • fontSize this functionality is not granular at node level. This would be a feature request instead.

I would kindly ask you to go ahead and open a feature request for the fontSize. We will use this issue to track the bug on the renderLabel flag.

@volkantas
Copy link
Author

Sure @danielcaldas,

Related future request is here: #330

danielcaldas added a commit that referenced this issue Jul 3, 2020
@danielcaldas
Fix #322
669fe23
@danielcaldas danielcaldas changed the title fontSize and renderLabel params are not working for single node renderLabel params are not working for single node Jul 3, 2020
@danielcaldas danielcaldas mentioned this issue Jul 3, 2020
Merged
danielcaldas added a commit that referenced this issue Jul 3, 2020
@danielcaldas
Misc improvements cleanup from previous PRs (#327)
889044a 
* Misc improvements cleanup from previous PRs

-  Revert DOCUMENTATION.md to previous version
- Adjustments in documentation
- Add copy to clipboard button to sandbox for graph configuration field
- Remove eslint rule new-line-after-var
- Small refactor around graph.builder and graph.helper
- Small refactor marker.helper

* Small improvements in sandbox improve copy to clipboard

* Fix unit test

* Add sample for new size API @terahn #342

* Allow users to select the node.labelPosition in the form

* Fix #322

* Fix #323
@danielcaldas
Copy link
Owner

Released in react-d3-graph 2.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug priority high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Misc improvements cleanup from previous PRs danielcaldas/react-d3-graph
2 participants
@volkantas @danielcaldas