Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle stringly keyed maps! #8

Merged
merged 2 commits into from
Jun 19, 2020
Merged

Handle stringly keyed maps! #8

merged 2 commits into from
Jun 19, 2020

Conversation

erlandsona
Copy link

@erlandsona erlandsona commented May 19, 2020 •
edited
Loading

This enables syntax in Phoenix controllers per the following.

import Destructure
def index(conn, s(%{id})), do: MyEctoModel |> Repo.get(id)

Austin Erlandson added 2 commits May 19, 2020 13:50
Handle stringly keyed maps!
1904c8e
Change to s macro because d(%s{}) should be kept when assigning a Str…
ddd2606 
…uct to a pattern variable, and d(s%{}) gets mix formatted to d(s(%{})) which is ugly.
@erlandsona
Copy link
Author

@danielberkompas ?

@danielberkompas
Copy link
Owner

Looks good, thanks!

@danielberkompas danielberkompas merged commit d3d65db into danielberkompas:master Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erlandsona @danielberkompas