Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(Cloak.Config.all/0): Find ciphers by checking if the module … #47

Merged
merged 1 commit into from
Jan 6, 2018
Merged

refactor(Cloak.Config.all/0): Find ciphers by checking if the module … #47

merged 1 commit into from
Jan 6, 2018

Conversation

tomciopp
Copy link
Contributor

@tomciopp tomciopp commented Jan 6, 2018

…exports the Cloak.Cipher behaviour

This is a refactor for the Cloak.Config.all/0 method discussed in #43. Instead of blacklisting atoms it will check if the module is a Cloak.Cipher.

danielberkompas
danielberkompas approved these changes Jan 6, 2018
View reviewed changes
Copy link
Owner

@danielberkompas danielberkompas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ⭐ ⭐ ⭐

@danielberkompas danielberkompas merged commit ae1f666 into danielberkompas:master Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielberkompas danielberkompas danielberkompas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomciopp @danielberkompas