Misc fixes and clean-up #1154
Merged
Misc fixes and clean-up #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotGovUK
|
||||||||||||||||||||||||||||||
| Project |
NotGovUK
|
| Branch Review |
fix-generators
|
| Run status |
|
| Run duration | 12m 04s |
| Commit |
|
| Committer | Daniel A.C. Martin |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
1
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
NotGovUK
|
||||||||||||||||||||||||||||||
| Project |
NotGovUK
|
| Branch Review |
fix-generators
|
| Run status |
|
| Run duration | 13m 12s |
| Commit |
|
| Committer | Daniel A.C. Martin |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
21
|
|
Skipped
|
0
|
|
Passing
|
84
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Moves the global overrides into the components, wherever possible. In the long run, it would be nice to make the overrides 'opt-in' but we probably need govuk-frontend to provide modules for that.
We are stuck with this until govuk-frontend updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix #991.
Has BREAKING change by tightening React peer-dependencies.