BREAKING: Update react-helmet-async to v2 #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests failing; see: staylor/react-helmet-async#208 Possible fix: staylor/react-helmet-async#230 i.e: Likely to be fixed in v2.0.6 |
NotGovUK
|
||||||||||||||||||||||||||||||
| Project |
NotGovUK
|
| Branch Review |
react-helmet-async-v2
|
| Run status |
|
| Run duration | 12m 05s |
| Commit |
|
| Committer | Daniel A.C. Martin |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
0
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Tests for review
daniel-ac-martin
force-pushed
the
react-helmet-async-v2
branch
from
486e169
to
4a4a79a
Compare
There appears to be a bug in which named imports do not work. This bug only appears for us when running under Jest, but not when bundling with webpack. This workaround allows us to import react-helmet-async in different contexts. If this issue is fixed upstream, then this commit can be reverted. See: staylor/react-helmet-async#208
daniel-ac-martin
force-pushed
the
react-helmet-async-v2
branch
from
4a4a79a
to
99cb418
Compare
daniel-ac-martin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presumably this is a breaking change as it is a major version bump on a context providing package.