-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use $q for the upload service #46
Comments
There is no easy way to attach the progress listener to the angular's XmlHttpRequest after it is send that's why it needs to be part of options. |
Ok I found a workaround. This should be fixed now you don't need to call |
You should be aware that using the .notify() method on the $q deferred means that you need at least angular 1.2 I was using 1.0.8 and the $q on that doesn't support that method. |
It is optional if you don't want to use notify just put the progress as an option or call .progress() on the returned promise for 1.0.8 |
Ah right, okay. Thanks. |
It would be good if the library returned it's own deferred instead of $http's. This would allow it to also use $q's notify() method to update the progress of the upload instead of having it as a passed option which requires a $apply to do stuff to the scope?
Hope this is clear.
The text was updated successfully, but these errors were encountered: