Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libraries #298

Merged
merged 3 commits into from
Dec 25, 2024
Merged

Update libraries #298

merged 3 commits into from
Dec 25, 2024

Conversation

grine4ka
Copy link
Contributor

@grine4ka grine4ka commented Dec 11, 2024

Due to some strange errors I was not able to compile Dangerfile_ci.df.kts on my Mac.
The error looks like this:

java.lang.NoSuchMethodError: 'long kotlin.time.DurationKt.getSeconds(long)'

        at kotlinx.datetime.Instant.minus-5sfh64U(Instant.kt:46)
        at Dangerfile_ci_df.<init>(Dangerfile_ci.df.kts:76)

Though there is OptIn(ExperimentalTime::class).

The solution was to update kotlinx-datetime library to the latest version.
Also updated kotlinx-serialization-json and kotlinx-coroutines-core to the versions that use Kotlin 2.0.

P.S. While trying to check my fixes found out that libncurses5 package doesn't exist on ubuntu-latest. I also was not able to find the reasons for this step on CI.

UPD:
Also find out that danger-js version is still 11.3.1 inside danger-kotlin docker image 1.3.2. No build arguments were passed to release job

- Update versions kotlinx-serialization-json, kotlinx-datetime and kotlinx-coroutines-core to ones that support Kotlin 2.0
- Remove unnecessary step on CI
- Update danger-js inside Docker image
- Update publish docker image arguments on release job
@grine4ka grine4ka changed the title Update kotlin libraries Update libraries Dec 20, 2024
- Removed on workflow dispatch inputs
@Vacxe Vacxe merged commit ab04ec7 into danger:master Dec 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants