AA voice search improvements #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specific song requests weren't doing anything, and requests to 'play some (artist)' would queue up albums in chronological order. Single songs now working, and artist requests will shuffle which is in line with other services like spotify etc.
daneren2005
reviewed
Sep 12, 2018
| @@ -421,7 +421,7 @@ protected Void doInBackground(MusicService musicService) throws Throwable { | |||
| } | |||
|
|
|||
| private void playSong(Entry entry) { | |||
|
|
|||
| playSong(entry, false); | |||
There was a problem hiding this comment.
😆 Oh man I really had a blank function there? Good catch
|
Looks good. I am merging in but it is not in todays release |
|
Thanks! |
t-m-w
pushed a commit
to t-m-w/Subsonic
that referenced
this pull request
Jul 15, 2020
AA voice search improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specific song requests weren't doing anything, and requests to 'play
some (artist)' would queue up albums in chronological order.
Single songs now working, and artist requests will shuffle which is in
line with other services like spotify etc.