Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add releaseNotes property to published dandiset #185

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

satra
Copy link
Member

@satra satra commented Jun 19, 2023

this will allow change of the UI to add a field alongside publishing for releaseNotes.

we should also consider adding optional CHANGES and README files to the Dandiset model.

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c3a74cc) 97.66% compared to head (1d3e6c1) 97.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #185   +/-   ##
=======================================
  Coverage   97.66%   97.66%           
=======================================
  Files          18       18           
  Lines        1799     1801    +2     
=======================================
+ Hits         1757     1759    +2     
  Misses         42       42           
Flag Coverage Δ
unittests 97.66% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dandischema/models.py Outdated Show resolved Hide resolved
@yarikoptic
Copy link
Member

better add some record to some unittest to exercise this optional field, so there would be a "detector" for removing/breaking it.

@yarikoptic yarikoptic added the patch Increment the patch version when merged label Feb 3, 2024
@yarikoptic
Copy link
Member

hm, I am confused why schemata version is not changed... we are adding a field so should get at least a patch version boost I guess in comparison to the latest release -- may be back then we had already some changes staged. Should rebase/push again and see what happens. will do now

dandischema/models.py Outdated Show resolved Hide resolved
@satra
Copy link
Member Author

satra commented Feb 3, 2024

this will indeed have a schema change, but we only added the update to schema version in a relevant corresponding PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants