Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: embargoedUntil -- extend semantic to be able to mark with the date when it was unembargoed #143

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yarikoptic
Copy link
Member

The motivation is to (ab)use this metadata field to enable annotating dandisets which were unembargoed in the archive. ATM it would be impossible (?) to tell from dandiset metadata if it was unemabrgoed since we do not carry much (if any) of provenance. Whenever we unemabrgo a dandiset we could use this field then to fill-in datetime for when it was unembargoed, which would actually be "semantically" correct since that would be the date time until when it was embargoed. Of cause if the intention of this field is more of "unembargoUntil" (so no "done" notion), then it must remain as is.

If merged -- TODO: file an issue with dandi-archive to fill-in this field (possibly overwriting an existing value) upon "unembargo" action for the dandiset.

…te when it was unemabroed

The motivation is to (ab)use this metadata field to enable annotating
dandisets which were unembargoed in the archive. ATM it would be impossible (?)
to tell from dandiset metadata if it was unemabrgoed since we do not carry
much (if any) of provenance.  Whenever we unemabrgo a dandiset we could use
this field then  to fill-in datetime for when it was unembargoed, which would
actually be "semantically" correct since that would be the date time until when
it was embargoed.  Of cause if the intention of this field is more of "unembargoUntil"
(so no "done" notion), then it must remain as is
@satra
Copy link
Member

satra commented Sep 20, 2022

this will cause a change to the schema. but i think the field can be used when unembargo happens. so i would suggest doing the archive change first and use the field.

in terms of provenance, i've talked about a full audit log that's different from the schema. i think it should be prioritized once current issue are resolved. cc/ (@waxlamp)

@yarikoptic yarikoptic added the patch Increment the patch version when merged label Sep 20, 2022
@yarikoptic
Copy link
Member Author

this will cause a change to the schema

rright... since such a minor change as a doc, I think we could make it just a patch and delay actual release until some other change "pushes it out"

but i think the field can be used when unembargo happens. so i would suggest doing the archive change first and use the field.

coolio, so we are inline in our thinking then. Filed dandi/dandi-archive#1286

@yarikoptic
Copy link
Member Author

ok, I will move it to draft, and say that it is blocked by dandi/dandi-archive#1286

@yarikoptic yarikoptic marked this pull request as draft February 17, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants