Handle a key with length over 1024 as a long key. (jbeder#916)

Fixes jbeder#501
dand-oss · Oct 16, 2020 · 32e5a95 · 32e5a95
1 parent 470e520
commit 32e5a95
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/emitter.cpp b/src/emitter.cpp
@@ -708,7 +708,7 @@ Emitter& Emitter::Write(const std::string& str) {
       Utils::ComputeStringFormat(str, m_pState->GetStringFormat(),
                                  m_pState->CurGroupFlowType(), stringEscaping == StringEscaping::NonAscii);
 
-  if (strFormat == StringFormat::Literal)
+  if (strFormat == StringFormat::Literal || str.size() > 1024)
     m_pState->SetMapKeyFormat(YAML::LongKey, FmtScope::Local);
 
   PrepareNode(EmitterNodeType::Scalar);

diff --git a/test/integration/emitter_test.cpp b/test/integration/emitter_test.cpp
@@ -266,16 +266,23 @@ TEST_F(EmitterTest, SimpleLongKey) {
 }
 
 TEST_F(EmitterTest, SingleLongKey) {
+  const std::string shortKey(1024, 'a');
+  const std::string longKey(1025, 'a');
   out << BeginMap;
   out << Key << "age";
   out << Value << "24";
   out << LongKey << Key << "height";
   out << Value << "5'9\"";
   out << Key << "weight";
   out << Value << 145;
+  out << Key << shortKey;
+  out << Value << "1";
+  out << Key << longKey;
+  out << Value << "1";
   out << EndMap;
 
-  ExpectEmit("age: 24\n? height\n: 5'9\"\nweight: 145");
+  ExpectEmit("age: 24\n? height\n: 5'9\"\nweight: 145\n" + shortKey +
+             ": 1\n? " + longKey + "\n: 1");
 }
 
 TEST_F(EmitterTest, ComplexLongKey) {