Skip to content

Incorrectly uses usize instead of u64 for file offsets #67

@peter-bertok

Description

@peter-bertok

As per the discussion here: https://users.rust-lang.org/t/rust-beginner-notes-questions/14928/81?u=peter_bertok

The file offset should be consistently u64 everywhere instead of usize, even on 32-bit platforms. In practice, I believe Windows doesn't actually support mapping more than 2 GB on 32-bit, so isize::MAX might be a better window-size limit.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions