Do not enforce websocket restriction on proxy#1
Closed
acormier-maia wants to merge 1 commit intodanbailey1000:proxy-feature-cleanfrom
Closed
Do not enforce websocket restriction on proxy#1acormier-maia wants to merge 1 commit intodanbailey1000:proxy-feature-cleanfrom
acormier-maia wants to merge 1 commit intodanbailey1000:proxy-feature-cleanfrom
Conversation
An HTTP Proxy with Connect can proxy any tcp connection not just http. Remove the restriction that the leafnode connection must be websocket. Signed-off-by: Your Name <austincormier@maiaedge.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the restriction that the leaf node connection must be a websocket in order to enable proxy support. I have tested locally and confirms it works.
Signed-off-by: Austin Cormier austincormier@maiaedge.io