-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Url Mime Caching #743
base: master
Are you sure you want to change the base?
Url Mime Caching #743
Conversation
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Review for "Url Mime Caching" #743 Here's a brief review of your PR: Handling the HEAD Response: There's a subtlety in ehttp_get_mime_type. When the server returns an error or fails to include a Content-Type header, the promise is • The in_flight entry for that URL remains in the HashMap forever. You likely want to call sender.send(...) in both success and failure paths so that the promise always completes, or otherwise remove the promise from the in_flight |
shouldn't this be a part of imagecache? do we really want to prop drill this independently? |
If the mime type hosted at a URL can't be inferred from the URL, a HEAD request is made and the result is cached. Every so often the data structure is saved to disk