WIP: subman API #561
Draft
WIP: subman API #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I bet we could make the |
|
I'm missing the outer flow on outbox ... is this right?:
OutboxRelays means "make sure we have at least one of these in our active set" |
|
It might be useful to have a |
|
liking the sounds of this so far! |
ksedgwic
force-pushed
the
2024-12-submgr-sketch
branch
from
6edfa9c to
a2f9e6c
Compare
Is the second commit a good thing? I used an Arc<Mutex> to calm rust re: the SubMgr reference issues ... |
ksedgwic
force-pushed
the
2024-12-submgr-sketch
branch
3 times, most recently
from
e469fe3 to
c5969bf
Compare
ksedgwic
force-pushed
the
2024-12-submgr-sketch
branch
from
c5969bf to
e92e6ca
Compare
jb55
reviewed
Dec 18, 2024
ksedgwic
force-pushed
the
2024-12-submgr-sketch
branch
from
e92e6ca to
084bd54
Compare
ksedgwic
force-pushed
the
2024-12-submgr-sketch
branch
3 times, most recently
from
ea0425e to
c769a6e
Compare
|
Renamed to subman |
ksedgwic
force-pushed
the
2024-12-submgr-sketch
branch
4 times, most recently
from
d503afa to
cd41b1c
Compare
ksedgwic
force-pushed
the
2024-12-submgr-sketch
branch
2 times, most recently
from
d686f7a to
b9ca1ef
Compare
ksedgwic
force-pushed
the
2024-12-submgr-sketch
branch
from
b9ca1ef to
bd9060c
Compare
ksedgwic
changed the title
Consider changing the actual update of the Muted struct to polled instead of synchronized.
actually the old one was mut, now mut and !mut versions available
Next: close relays when no subscriptions need them
- local relays are very doable, but not sure if we want them - forced relays want to be implemented in the pool/subman and need more definition
ksedgwic
force-pushed
the
2024-12-submgr-sketch
branch
from
bd9060c to
2ecde85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.