initial post reply view #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Casarin <[email protected]>
|
@robagreda got it pixel perfect this time! |
Signed-off-by: William Casarin <[email protected]>
|
Looks good! But it needs a |
Suggested-by: kernelkind <[email protected]> Signed-off-by: William Casarin <[email protected]>
|
On Sat, Jun 22, 2024 at 01:53:34PM GMT, kernelkind wrote:
Looks good! But it needs a `ScrollArea` because if the note you're replying to is larger than the screen then you can't get to the post box
good call, added
|
|
This looks great @jb55 should we add a placeholder saying like: type your reply here... something like that? |
|
On Mon, Jun 24, 2024 at 05:15:29PM GMT, Roberto wrote:
This looks great @jb55 should we add a placeholder saying like: type your reply here... something like that?
yup will add this!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i spent way too much time implementing the line drawing