feat: support ng-add for standalone applications #1800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timdeschryver
force-pushed
the
standalone-ng-add
branch
from
a161ed9 to
dc80a99
Compare
timdeschryver
commented
Jul 8, 2023
| @@ -1,5 +1,6 @@ | |||
| // Public classes. | |||
|
|
|||
| export { PassedInitialConfig } from './auth-config'; | |||
There was a problem hiding this comment.
Needed to be used to configure a standalone application in a type-safe way.
timdeschryver
force-pushed
the
standalone-ng-add
branch
from
89aa922 to
a8a6cce
Compare
timdeschryver
commented
Jul 8, 2023
| @@ -24,7 +24,7 @@ const IFRAME_SILENT_RENEW = `{ | |||
|
|
|||
| const AZURE_AD_SILENT_RENEW = `{ | |||
| authority: 'https://login.microsoftonline.com/<authorityUrlOrTenantId>/v2.0', | |||
| authWellknownEndpoint: 'https://login.microsoftonline.com/common/v2.0', | |||
| authWellknownEndpointUrl: 'https://login.microsoftonline.com/common/v2.0', | |||
There was a problem hiding this comment.
While testing the migration this gave a compile error, so I renamed this property to match the type.
timdeschryver
force-pushed
the
standalone-ng-add
branch
from
f4e622b to
b9698f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to do some more tests, but I already created the PR for initial feedback and to let you know that I've started this.
Closes #1798
A first test seems like the default migration works for standalone applications.
Here's an overview of the changes in an empty application:
And it still works for a module based application: