Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "language" prop to CodeEditor #54

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

Ademking
Copy link
Contributor

@Ademking Ademking commented Nov 13, 2024

Add Props to "CodeEditor" for Enhanced Flexibility

Description

This PR introduces props to the component to improve its flexibility and usability.

Type of Change

  • New feature (non-breaking change which adds functionality)

Checklist

Please ensure your PR fulfills the following requirements:

  • I have read and followed the Contributing Guidelines.
  • My code follows the code style of this project.
  • My code respect as much as possible the W3C standards with corresponding ARIA roles and html semantics.
  • I have performed a self-review of my code.
  • I have commented my code (if necessary), particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings.

Copy link

vercel bot commented Nov 13, 2024

@Ademking is attempting to deploy a commit to the Damien Schneider's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cuicui ✅ Ready (Inspect) Visit Preview 💬 3 unresolved Nov 13, 2024 5:12pm

@damien-schneider
Copy link
Owner

This is a great enhancement! Adding language prop significantly improves the flexibility of the component. Thank you very much for your contribution!

@damien-schneider damien-schneider merged commit b41185e into damien-schneider:main Nov 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants