Fix Request in scope non request

http://symfony.com/doc/2.3/cookbook/service_container/scopes.html#using- a-synchronized-service
damianociarla · Dec 10, 2014 · 79410eb · 79410eb
1 parent 8b0cc82
commit 79410eb
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 6 deletions.
diff --git a/EventListener/RatingUpdateInfoEventListener.php b/EventListener/RatingUpdateInfoEventListener.php
@@ -11,15 +11,18 @@
 class RatingUpdateInfoEventListener implements EventSubscriberInterface
 {
     /**
-     * @var \Symfony\Component\HttpFoundation\Request
+     * @var Request
      */
     private $request;
 
-    public function __construct(Container $container)
+    /**
+     * Set request
+     *
+     * @param Request $request
+     */
+    public function setRequest(Request $request = null)
     {
-        $container->enterScope('request');
-        $container->set('request', new Request(), 'request');
-        $this->request = $container->get('request');
+        $this->request = $request;
     }
 
     public static function getSubscribedEvents()
@@ -31,6 +34,10 @@ public static function getSubscribedEvents()
 
     public function updatePermalink(RatingEvent $event)
     {
+        if (null === $this->request) {
+            return;
+        }
+
         $rating = $event->getRating();
 
         if (null === $rating->getPermalink()) {

diff --git a/Resources/config/event.xml b/Resources/config/event.xml
@@ -15,7 +15,9 @@
             <tag name="kernel.event_listener" event="kernel.exception" method="onKernelException" />
         </service>
         <service id="dcs_rating.listener.rating_update_info" class="%dcs_rating.listener.rating_update_info.class%">
-            <argument type="service" id="service_container" />
+            <call method="setRequest">
+                <argument type="service" id="request" on-invalid="null" strict="false" />
+            </call>
             <tag name="kernel.event_subscriber" />
         </service>
         <service id="dcs_rating.listener.rating_update_rate" class="%dcs_rating.listener.rating_update_rate.class%">