Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed styling #7

Merged
merged 1 commit into from
Feb 4, 2016
Merged

Fixed styling #7

merged 1 commit into from
Feb 4, 2016

Conversation

barfittc
Copy link
Contributor

@barfittc barfittc commented Feb 3, 2016

Upped to version 0.10.0

Rearranged style of quickSelect
I move the selectors to a paper-dropdown-menu, in the top area, along with the next/previous month buttons.
On a side note. There's some old used CSS classes that need to get filtered and removed.

Removed dependency to autonotify_observe
I removed the autonotify_observe because it seems more logical to have a more general library (less dependencies the better!), and because autonotify_observe was crashing everything for me..

Rearranged style of quickSelect
upped to version 0.10.0
@dam0vm3nt
Copy link
Owner

For this single component I'm positive to get rid of autonotify.

But can you tell me your issues with autonotify ? I'm using it in a pretty big project without any problem since two months now.

@barfittc
Copy link
Contributor Author

barfittc commented Feb 4, 2016

The main issue was, I was having trouble getting dependencies to work with it. It started when this one showed up. dart-archive/polymer-dart#665 Since then, I haven't been able to get a pub get or pub upgrade working with autonotify included, with any version of autonotify.

@dam0vm3nt
Copy link
Owner

So after all seams that your problems were not related to autonotify at all!
BTW dart-archive/polymer-dart#665 seams to be fixed now.

Whatever I was already thinking of removing autonotify from this component for those reasons you already mentioned. But I was indecided because I feared that eventually I was going to miss it.

If there will be the case I'm sure you will help me to restore it!

I'm going to merge this by now. Wouldn't you mind if I enlist you in the pubspec authors ? Let me know.

dam0vm3nt added a commit that referenced this pull request Feb 4, 2016
@dam0vm3nt dam0vm3nt merged commit 1ccdb40 into dam0vm3nt:master Feb 4, 2016
@barfittc
Copy link
Contributor Author

barfittc commented Feb 4, 2016

Yeah, you can list me in the pubspec.
I can help with whatever pops up in the future.

@dam0vm3nt
Copy link
Owner

k, I'm going to make quickSelect the default behaviour, introducing the disable-quick-select attribute.
I think this will be the most common setup. Do you mind it ?

@dam0vm3nt
Copy link
Owner

ops, can't find your contact info anywhere. Will you please add yourself to the pubspec next time ?

@barfittc
Copy link
Contributor Author

barfittc commented Feb 5, 2016

No I do not mind, I was debating on that anyway.

Here's my info, I don't know how I would add multiple authors.
Chris Barfitt [email protected]
On Feb 4, 2016 6:47 PM, "Vittorio Ballestra" [email protected]
wrote:

ops, can't find your contact info anywhere. Will you please add yourself
to the pubspec next time ?


Reply to this email directly or view it on GitHub
#7 (comment)
.

@dam0vm3nt
Copy link
Owner

done

Il giorno ven 5 feb 2016 alle ore 01:59 barfittc [email protected]
ha scritto:

No I do not mind, I was debating on that anyway.

Here's my info, I don't know how I would add multiple authors.
Chris Barfitt [email protected]
On Feb 4, 2016 6:47 PM, "Vittorio Ballestra" [email protected]
wrote:

ops, can't find your contact info anywhere. Will you please add yourself
to the pubspec next time ?


Reply to this email directly or view it on GitHub
<
#7 (comment)

.


Reply to this email directly or view it on GitHub
#7 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants