-
Notifications
You must be signed in to change notification settings - Fork 2
chore(deps): consolidate verified dependency updates #656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
187a005
9593e58
f8bcb82
b997aa2
2e9245f
a36cd4b
76d08c8
13099c7
71117a1
61a2d68
7d406a2
46efee1
54ea879
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,7 @@ use axum::{ | |
| http::{HeaderMap, StatusCode}, | ||
| response::{IntoResponse, Json}, | ||
| }; | ||
| use hmac::{Hmac, Mac}; | ||
| use hmac::{Hmac, KeyInit, Mac}; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# 1) Confirm there are indeed two definitions of verify_whatsapp_signature.
rg -nP --type=rust -C2 '\bfn\s+verify_whatsapp_signature\b'
# 2) Inspect the mod.rs version's imports to see if KeyInit is brought in elsewhere in the file/module.
rg -nP --type=rust -C1 '\buse\s+hmac::' clients/agent-runtime/src/gateway/
# 3) Find which version is actually exported/used by callers (router wiring, re-exports).
rg -nP --type=rust -C2 '\bverify_whatsapp_signature\b'
# 4) Check whether mod.rs re-exports the whatsapp.rs version (which would make the mod.rs copy dead code).
rg -nP --type=rust -C1 '\bpub\s+use\s+.*whatsapp' clients/agent-runtime/src/gateway/mod.rsRepository: dallay/corvus Length of output: 13562 Deduplicate Two separate implementations of Keep 🤖 Prompt for AI Agents |
||
| use sha2::Sha256; | ||
| use crate::gateway::AppState; | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -27,6 +27,6 @@ | |||||
| "astro-vtbot": "catalog:", | ||||||
| "portless": "catalog:", | ||||||
| "typescript": "catalog:", | ||||||
| "vite": "7.3.2" | ||||||
| "vite": "8.0.10" | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: # First, check if the files exist and examine the package.json
find . -name "package.json" -path "*/clients/web/apps/docs/*" | head -5Repository: dallay/corvus Length of output: 94 🏁 Script executed: # Look for pnpm-workspace.yaml
find . -name "pnpm-workspace.yaml" | head -5Repository: dallay/corvus Length of output: 113 🏁 Script executed: # List files in the relevant directory
git ls-files clients/web/apps/docs/ | head -20Repository: dallay/corvus Length of output: 1335 🏁 Script executed: # Examine the package.json file to check line 30 and devDependencies
cat -n clients/web/apps/docs/package.json | grep -A 30 -B 5 "vite"Repository: dallay/corvus Length of output: 286 🏁 Script executed: # Get the full package.json to see all devDependencies
cat -n clients/web/apps/docs/package.jsonRepository: dallay/corvus Length of output: 1363 🏁 Script executed: # Examine pnpm-workspace.yaml, especially line 32 and context
cat -n clients/web/pnpm-workspace.yaml | head -50Repository: dallay/corvus Length of output: 1260 🏁 Script executed: # Also check the root pnpm-workspace.yaml to understand the catalog setup
cat -n pnpm-workspace.yaml | grep -A 5 -B 5 "vite"Repository: dallay/corvus Length of output: 722 🏁 Script executed: # Check if there are any comments in clients/web/pnpm-workspace.yaml explaining the Vite/Astro issue
cat clients/web/pnpm-workspace.yamlRepository: dallay/corvus Length of output: 966 🏁 Script executed: # Check Vite 8 and Astro 6.1 compatibility via web search would be better, but first let's see if there are any comments in the file
rg -i "vite|astro" clients/web/pnpm-workspace.yaml -B 2 -A 2Repository: dallay/corvus Length of output: 620 🏁 Script executed: # Search for any comments in the codebase mentioning vite and astro compatibility issues
rg -i "vite.*astro|astro.*vite" --type-list | head -20Repository: dallay/corvus Length of output: 447 🏁 Script executed: # Check git history or comments about this hard pin
rg -i "vite|astro" clients/web/apps/docs/ -B 3 -A 3 --type-listRepository: dallay/corvus Length of output: 447 🏁 Script executed: # Look for any issue tracking or TODO comments in the entire clients/web directory
rg -i "todo|fixme|bug|issue" clients/web/ --type-list | grep -i "vite\|astro"Repository: dallay/corvus Length of output: 447 🏁 Script executed: # Check astro.config.mjs to see if there's any indication of compatibility issues
cat -n clients/web/apps/docs/astro.config.mjsRepository: dallay/corvus Length of output: 10654 🏁 Script executed: # Search for any TODO, FIXME, or comments about vite/astro in the codebase
rg "TODO|FIXME|NOTE|BUG" clients/web/ -B 2 -A 2Repository: dallay/corvus Length of output: 1792 🏁 Script executed: # Look for any issues or comments in git history about vite pinning
git log --all --oneline --grep="vite" | head -10Repository: dallay/corvus Length of output: 656 🏁 Script executed: # Check if there are other package.json files with similar patterns to understand the intent
find clients/web -name "package.json" -exec grep -l "vite" {} \;Repository: dallay/corvus Length of output: 259 🏁 Script executed: # Check how other apps handle vite in their package.json
for file in clients/web/apps/dashboard/package.json clients/web/apps/marketing/package.json clients/web/apps/rook-dashboard/package.json; do
echo "=== $file ==="
cat "$file" | grep -A 10 "devDependencies"
doneRepository: dallay/corvus Length of output: 1063 🏁 Script executed: # Check the git commit history for the vite hard pin to understand why it was done
git log -p --all -- clients/web/apps/docs/package.json | grep -B 10 -A 10 "vite.*8.0.10" | head -40Repository: dallay/corvus Length of output: 39 🏁 Script executed: # Verify Vite 8 and Astro 6.1 compatibility - let's look at package lock files
rg "vite.*8.0.10|astro.*6.1" clients/web/apps/docs/pnpm-lock.yaml -B 2 -A 2 | head -20Repository: dallay/corvus Length of output: 832 🏁 Script executed: # Let's check the full git history to see if there was an issue or discussion
git log --all --format="%h %s" --grep="astro\|vite" | head -20Repository: dallay/corvus Length of output: 1575 🏁 Script executed: # Search for any comments or issues in markdown files about vite/astro incompatibility
rg -i "vite.*astro|astro.*vite|incompatible|break" clients/web/ --type mdRepository: dallay/corvus Length of output: 405 🏁 Script executed: # Let's check what version of Astro is actually being used in the lock file
rg "astro@" clients/web/apps/docs/pnpm-lock.yaml | head -5Repository: dallay/corvus Length of output: 543 🏁 Script executed: # Check if marketing app also has the same issue and if this is deliberate
cat -n clients/web/apps/marketing/package.jsonRepository: dallay/corvus Length of output: 1536 🏁 Script executed: # Look for any recent commits specifically about the vite pin in these apps
git log --all -p -- clients/web/apps/docs/package.json clients/web/apps/marketing/package.json | grep -B 5 -A 5 "vite" | head -50Repository: dallay/corvus Length of output: 1478 🏁 Script executed: # Check what the actual resolved vite version is in the lock file
rg "vite@8" clients/web/apps/docs/pnpm-lock.yaml -B 2 -A 10 | head -30Repository: dallay/corvus Length of output: 39 🏁 Script executed: # Let me check when vite was bumped to 8.0.10 specifically
git log --all --oneline --follow -- clients/web/apps/docs/package.json clients/web/apps/marketing/package.json | head -20Repository: dallay/corvus Length of output: 103 🏁 Script executed: # Check the specific commit that added 8.0.10
git show 0ef9b53 | head -100Repository: dallay/corvus Length of output: 5296 🏁 Script executed: # Find the specific commit that introduced vite 8.0.10
git log --all --oneline -- clients/web/apps/docs/package.json clients/web/apps/marketing/package.json | xargs -I {} git show {} | grep -B 5 "vite.*8.0.10" | head -30Repository: dallay/corvus Length of output: 2756 🏁 Script executed: # More direct search for when vite 8.0.10 was introduced
git log --all -p -- clients/web/apps/docs/package.json | grep -B 20 "8.0.10" | head -50Repository: dallay/corvus Length of output: 884 🏁 Script executed: # Let me check if there are any build or runtime errors related to vite in the test logs or CI
find . -name "*.md" -o -name "*.txt" | xargs grep -l "vite.*astro\|astro.*vite" 2>/dev/null | head -10Repository: dallay/corvus Length of output: 69 🌐 Web query:
💡 Result: Astro 6.1 is not compatible with Vite 8. Astro 6 uses Vite 7 internally and actively warns against using Vite 8, as full support is still in progress (WIP PR Citations:
🏁 Script executed: # Check the README for any mention of vite/astro compatibility
cat README.md | grep -i "vite\|astro" -B 2 -A 2Repository: dallay/corvus Length of output: 1123 Change All other devDependencies use ♻️ Proposed change- "vite": "8.0.10"
+ "vite": "catalog:"📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| } | ||||||
| } | ||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,6 +28,6 @@ | |
| "devDependencies": { | ||
| "portless": "catalog:", | ||
| "typescript": "catalog:", | ||
| "vite": "7.3.2" | ||
| "vite": "8.0.10" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: cd /tmp && find . -name "package.json" -path "*/clients/web/apps/*" 2>/dev/null | head -5Repository: dallay/corvus Length of output: 39 🏁 Script executed: git ls-files clients/web/apps/ | grep -E "(package\.json|pnpm-workspace\.yaml)"Repository: dallay/corvus Length of output: 217 🏁 Script executed: cat -n clients/web/apps/marketing/package.json | sed -n '25,40p'Repository: dallay/corvus Length of output: 282 🏁 Script executed: cat -n clients/web/pnpm-workspace.yaml | sed -n '25,40p'Repository: dallay/corvus Length of output: 457 🏁 Script executed: cat -n clients/web/pnpm-workspace.yaml | sed -n '1,30p'Repository: dallay/corvus Length of output: 969 🏁 Script executed: for file in clients/web/apps/*/package.json; do
echo "=== $file ===";
grep -A2 '"devDependencies"' "$file" | grep -E '"vite"|"astro"' || true;
doneRepository: dallay/corvus Length of output: 249 🏁 Script executed: for file in clients/web/apps/*/package.json; do
echo "=== $(basename $(dirname $file)) ===";
sed -n '/"devDependencies"/,/^ }/p' "$file" | grep -E '"(vite|astro)"';
doneRepository: dallay/corvus Length of output: 219 🌐 Web query:
💡 Result: Astro 6.1 is incompatible with Vite 8. Astro 6.1 requires Vite ^7 (specifically ^7.3.1 as seen in dependencies for Astro 6.x), and explicitly warns users when Vite 8 is detected. Full support for Vite 8 is in progress via an open pull request but not yet merged into a stable release as of 2026-04-25. To avoid issues: - Do not install or override to Vite 8. - If using packages that hoist Vite 8 (e.g., Citations:
Align with catalog dependency management, but note the root cause is incompatibility in the catalog itself. The hard-pinned version is inconsistent with the catalog pattern (though 🤖 Prompt for AI Agents |
||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: dallay/corvus
Length of output: 35023
🏁 Script executed:
Repository: dallay/corvus
Length of output: 720
Resolve dependency duplication before merging.
The lock file contains multiple major version conflicts in the resolved graph that require active resolution:
const-oid: both 0.9.6 and 0.10.2 presenthmac: both 0.12.1 and 0.13.0 presentsha2: both 0.10.9 and 0.11.0 presenttokio-tungstenite: both 0.28.0 and 0.29.0 presentLikely causes are transitive pulls from
sigstoreandx509-certconflicting with your direct pins. Verify that call sites handle the API changes correctly:rusqlite::params!macro andConnectionmethods (v0.38→0.39 tightened error types)cron::Schedule::Atpatterns intools/schedule.rstokio_tungstenite::connect_asyncin channels (qq.rs, lark.rs, dingtalk.rs, discord.rs)Run
cargo tree -dto identify which transitive deps are pulling older versions, then either update those upstream deps or add explicit constraints to unify versions.Also applies to: 109-109, 122-122, 128-128, 219-219
🤖 Prompt for AI Agents