make the default color of cells configurable #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlax
force-pushed
the
color-config
branch
3 times, most recently
from
482a477
to
8e5a1f3
Compare
dlax
force-pushed
the
color-config
branch
2 times, most recently
from
fe4419c
to
647cfaf
Compare
It's more explicit than 'yellow'.
We get rid of the colors.FIELD_BY_MODE dict and: - define PINNED_COLOR and FOCUSED_COLOR when rows are pinned or focused; - let the functions in colors module return the color name directly, instead of previously indirecting to FIELD_BY_MODE dict; - move default color values UI.make() body. Also, the methods and attributes of types.Column are changed a bit: now 'default_color' holds the default color (or None when "normal" should be used, but we don't repeat it there) and value_color() is the callable (typically a function from 'colors' module), previously name color_key().
We need to use a real class, not a dict anymore; but we keep the mapping interface.
This only applies to columns with a fixed color, i.e. that does not depend on the value (like do the 'time' or 'state' columns). Although this limitation is not handled in the Configuration class, we intercept invalid 'color' option in column configuration while loading the types.UI object and still return a ConfigurationError so that the user experience is quite similar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #407