Updated deps #369
Closed
Updated deps #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires a major version bump, as it is a breaking change. Because
curve25519-dalekexposes itsranddependency, if another crate previously used anOsRngfrom v0.7 to generate a scalar (which e.g.ed25519-dalekdoes), it would not compile anymore. This seemed awkward to me but it looks likemerlindoes this too.Notes on dependency updates:
byteorder = "1"is the line that's used in byteorder's own READMEsubtleis semantic-versioned (check me on this)fiat_cryptoto0.1because I have no idea how it's versioned. Thankfully it's bug-free by definition, so that's not an issue >.>